codecov-io
commented
5 years ago Codecov Report
Merging #199 into master will increase coverage by
70.9%. The diff coverage is100%.
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 28.34% 99.24% +70.9%
==========================================
Files 44 19 -25
Lines 2565 2123 -442
==========================================
+ Hits 727 2107 +1380
+ Misses 1838 16 -1822| Impacted Files | Coverage Δ | |
|---|---|---|
| spec/google/gax/api_callable_spec.rb | 97.81% <100%> (ø) |
|
| lib/google/gax/settings.rb | 99.09% <100%> (ø) |
|
| lib/google/gax/grpc.rb | 94.11% <0%> (-5.89%) |
:arrow_down: |
| lib/google/gax.rb | 100% <0%> (ø) |
:arrow_up: |
| lib/google/gax/grpc/status_details.rb | ||
| ...oogle/gax/paged_enumerable/format_resource_test.rb | ||
| lib/google/gax/stream_input.rb | ||
| lib/google/gax/api_call.rb | ||
| lib/google/gax/configuration/derived.rb | ||
| test/google/gax/grpc/stub_test.rb | ||
| ... and 51 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update f5c6818...963e391. Read the comment docs.
So there's good news and bad news.
:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the
cla/googlecommit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set theclalabel toyes(if enabled on your project), and then merge this pull request when appropriate.ℹ️ Googlers: Go here for more info.