Update page-streaming call options

googleapis / gax-ruby

Google API Extensions for Ruby

https://rubygems.org/gems/google-gax

BSD 3-Clause "New" or "Revised" License

20 stars 22 forks source link

Update page-streaming call options #20

Closed jmuk closed 8 years ago

jmuk commented 8 years ago

Retire is_page_streaming call options, we don't use this anymore.
Introduce page_token as a call option. This is similar to python implementation.
Unlike Python, Ruby provides per-page iteration as with another method 'each_page'. I believe this is still good for Ruby users.
Added example comments and a few fields for better usability of PagedEnumerable. I hope this helps.
related with #18.

jmuk commented 8 years ago

cc: @tbetbetbe

geigerj commented 8 years ago

Two small nits about the comments, otherwise LGTM.

What is the "codecov/patch" that is failing?

geigerj commented 8 years ago

LGTM

jmuk commented 8 years ago

I don't know hwy codecov looks broken -- the link itself is broken and I believe that's codecov's problem. The report https://codecov.io/gh/googleapis/gax-ruby/commit/d09e902f6e238011d765911441f1e58c0847ff93 seems fine to me. The "85%" means that 85% in the diff is covered by the tests, and that's mostly because of adding several accessors which are not used by tests.