Closed blowmage closed 5 years ago
Merging #201 into master will decrease coverage by
0.01%
. The diff coverage is25%
.
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 28.34% 28.33% -0.02%
==========================================
Files 44 44
Lines 2565 2566 +1
==========================================
Hits 727 727
- Misses 1838 1839 +1
Impacted Files | Coverage Δ | |
---|---|---|
lib/google/gax/grpc/stub.rb | 29.16% <25%> (-1.27%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f5c6818...d58080c. Read the comment docs.
Merging #201 into master will decrease coverage by
0.02%
. The diff coverage is20%
.
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 28.34% 28.32% -0.03%
==========================================
Files 44 44
Lines 2565 2567 +2
==========================================
Hits 727 727
- Misses 1838 1840 +2
Impacted Files | Coverage Δ | |
---|---|---|
lib/google/gax/grpc/stub.rb | 28% <20%> (-2.44%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f5c6818...7443708. Read the comment docs.
This PR adds the
channel_args
argument toGRPC::Stub.new
. This argument is used to initialize theGRPC::ClientStub
instance. It allows users to control the behavior of the stub object, including setting the size of the maximum request and response messages, which is very useful for services like BigQuery and Pub/Sub.Gax 1.0 did not have this, so clients were forced to create a
GRPC::Core::Channel
object using thechannel_args
argument and pass that in as thecredentials
argument. Adding thechannel_args
argument allows clients to pass aCredentials
object and still configure the GRPC behavior.This PR is used in the GAPIC Generator in googleapis/gapic-generator-ruby#150.