search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Allow Signet::OAuth2::Client as credential arg #202

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

Google Cloud supports Signet::OAuth2::Client as a credentials argument now. The Credentials class was originally intended to be a factory for creating Signet::OAuth2::Client objects, so it makes sense to support these objects.

GAPIC Generator adds support for this class to the configuration in googleapis/gapic-generator-ruby#151.

codecov[bot] commented 5 years ago

Codecov Report

Merging #202 into master will increase coverage by 0.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   28.32%   28.33%   +0.01%     
==========================================
  Files          44       44              
  Lines        2567     2566       -1     
==========================================
  Hits          727      727              
+ Misses       1840     1839       -1
Impacted Files Coverage Δ
lib/google/gax/grpc/stub.rb 29.16% <0%> (+1.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update feb51ed...88963e4. Read the comment docs.