googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Refactor Gax::GRPC::Stub to a class #206

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

Implement calling the RPC by calling a method on the Stub object instead of creating an ApiCall object. This allows us to fix the code that calls APIs in Gax instead of in the generator.

Generator support added in googleapis/gapic-generator-ruby#152.

codecov[bot] commented 5 years ago

Codecov Report

Merging #206 into master will increase coverage by 0.05%. The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   28.33%   28.38%   +0.05%     
==========================================
  Files          44       44              
  Lines        2566     2572       +6     
==========================================
+ Hits          727      730       +3     
- Misses       1839     1842       +3
Impacted Files Coverage Δ
lib/google/gax/paged_enumerable.rb 28.2% <25%> (-0.37%) :arrow_down:
lib/google/gax/grpc/stub.rb 34.48% <29.41%> (+5.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0b6499...ff68b8c. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #206 into master will increase coverage by 0.05%. The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   28.33%   28.38%   +0.05%     
==========================================
  Files          44       44              
  Lines        2566     2572       +6     
==========================================
+ Hits          727      730       +3     
- Misses       1839     1842       +3
Impacted Files Coverage Δ
lib/google/gax/paged_enumerable.rb 28.2% <25%> (-0.37%) :arrow_down:
lib/google/gax/grpc/stub.rb 34.48% <27.77%> (+5.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40e9181...cd1aa9b. Read the comment docs.