search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Call GAPIC client using positional args #208

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

This PR changes the Operations calls to the Operations Client to use positional arguments instead of the mixed positional/named arguments. This is needed to work around Protobuf adding the #to_hash method to the resource classes.

The generator side of this change is in googleapis/gapic-generator-ruby#155.

codecov[bot] commented 5 years ago

Codecov Report

Merging #208 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   28.33%   28.33%           
=======================================
  Files          44       44           
  Lines        2566     2566           
=======================================
  Hits          727      727           
  Misses       1839     1839
Impacted Files Coverage Δ
lib/google/gax/operation.rb 32.81% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0b6499...142b2e2. Read the comment docs.

blowmage commented 5 years ago

@quartzmo Since you approved googleapis/gapic-generator-ruby#155 can you approve this we well?