googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Add tests for recent changes #209

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

I mistakenly thought our test coverage was worse than it is. In fact, we had some errant focus calls that prevented the other tests from being run. When they were removed many recent features required changes to their tests.

codecov[bot] commented 5 years ago

Codecov Report

Merging #209 into master will increase coverage by 69.56%. The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #209       +/-   ##
===========================================
+ Coverage   28.38%   97.94%   +69.56%     
===========================================
  Files          44       44               
  Lines        2572     2577        +5     
===========================================
+ Hits          730     2524     +1794     
+ Misses       1842       53     -1789
Impacted Files Coverage Δ
test/google/gax/config/errors_test.rb 100% <ø> (ø) :arrow_up:
...ogle/gax/paged_enumerable/invalid_response_test.rb 80% <ø> (+64.61%) :arrow_up:
...oogle/gax/paged_enumerable/invalid_request_test.rb 100% <ø> (+80%) :arrow_up:
test/google/gax/operation_test.rb 100% <100%> (+72.69%) :arrow_up:
...ax/paged_enumerable/valid_request_response_test.rb 100% <100%> (+80%) :arrow_up:
...oogle/gax/paged_enumerable/format_resource_test.rb 100% <100%> (+82.6%) :arrow_up:
test/google/gax/grpc/stub_test.rb 100% <100%> (+62.5%) :arrow_up:
test/google/gax/paged_enumerable/enum_test.rb 92% <71.42%> (+72%) :arrow_up:
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6754442...86822bf. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #209 into master will increase coverage by 69.56%. The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #209       +/-   ##
===========================================
+ Coverage   28.38%   97.94%   +69.56%     
===========================================
  Files          44       44               
  Lines        2572     2577        +5     
===========================================
+ Hits          730     2524     +1794     
+ Misses       1842       53     -1789
Impacted Files Coverage Δ
test/google/gax/config/errors_test.rb 100% <ø> (ø) :arrow_up:
...ogle/gax/paged_enumerable/invalid_response_test.rb 80% <ø> (+64.61%) :arrow_up:
...oogle/gax/paged_enumerable/invalid_request_test.rb 100% <ø> (+80%) :arrow_up:
test/google/gax/operation_test.rb 100% <100%> (+72.69%) :arrow_up:
...ax/paged_enumerable/valid_request_response_test.rb 100% <100%> (+80%) :arrow_up:
...oogle/gax/paged_enumerable/format_resource_test.rb 100% <100%> (+82.6%) :arrow_up:
test/google/gax/grpc/stub_test.rb 100% <100%> (+62.5%) :arrow_up:
test/google/gax/paged_enumerable/enum_test.rb 92% <71.42%> (+72%) :arrow_up:
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6754442...86822bf. Read the comment docs.