googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Add headers helpers #210

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

Moving this common code to Gax so the GAPIC client can do less.

Generator uses this change in googleapis/gapic-generator-ruby#157.

codecov[bot] commented 5 years ago

Codecov Report

Merging #210 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   97.94%   97.96%   +0.02%     
==========================================
  Files          44       46       +2     
  Lines        2577     2608      +31     
==========================================
+ Hits         2524     2555      +31     
  Misses         53       53
Impacted Files Coverage Δ
lib/google/gax/headers.rb 100% <100%> (ø)
test/google/gax/headers/x_goog_api_client_test.rb 100% <100%> (ø)
lib/google/gax.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0df8531...70b5269. Read the comment docs.