googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Fix deadline calculation when timeout is nil #211

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

Allow for a nil timeout to mean a nil deadline.

codecov[bot] commented 5 years ago

Codecov Report

Merging #211 into 1.x will decrease coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #211      +/-   ##
==========================================
- Coverage   99.31%   99.26%   -0.05%     
==========================================
  Files          20       20              
  Lines        2174     2175       +1     
==========================================
  Hits         2159     2159              
- Misses         15       16       +1
Impacted Files Coverage Δ
lib/google/gax/api_callable.rb 97.76% <100%> (+0.01%) :arrow_up:
spec/google/gax/bundling_spec.rb 99.71% <0%> (-0.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6598d66...0a341b7. Read the comment docs.