Override retry options even if no retry codes were specified

googleapis / gax-ruby

Google API Extensions for Ruby

https://rubygems.org/gems/google-gax

BSD 3-Clause "New" or "Revised" License

20 stars 22 forks source link

Override retry options even if no retry codes were specified #212

Closed randypiper closed 5 years ago

randypiper commented 5 years ago

Previously, if a call's original CallSettings didn't specify any retry codes, they couldn't be overridden per-call via CallOptions. This change fixes that by checking the merged CallSettings (instead of the original CallSettings) to determine if a call should be retryable.

quartzmo commented 5 years ago

I ran the google-cloud-datastore ci and acceptance tasks against this branch and both passed.

Using google-gax 1.6.2 from https://github.com/randypiper/gax-ruby.git (at 1.x@672f2f5)

quartzmo commented 5 years ago

@randypiper Would it be possible to add unit test coverage for this fix to spec/google/gax/api_callable_spec.rb?