googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Disable gRPC service config lookup by default (1.x branch) #213

Closed dazuma closed 5 years ago

dazuma commented 5 years ago

Set the grpc.service_config_disable_resolution option on grpc channels by default, in the 1.x branch. See https://github.com/googleapis/gapic-generator/issues/2778. We will probably need to do something similar in the master branch.

/cc @noahdietz

dazuma commented 5 years ago

Looks like I'll need to update the mocks in the tests...

codecov[bot] commented 5 years ago

Codecov Report

Merging #213 into 1.x will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #213      +/-   ##
==========================================
+ Coverage   99.26%   99.26%   +<.01%     
==========================================
  Files          20       20              
  Lines        2175     2178       +3     
==========================================
+ Hits         2159     2162       +3     
  Misses         16       16
Impacted Files Coverage Δ
lib/google/gax/grpc.rb 94.44% <100%> (+0.32%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5f9e88...f7a7042. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #213 into 1.x will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #213      +/-   ##
==========================================
+ Coverage   99.26%   99.31%   +0.04%     
==========================================
  Files          20       20              
  Lines        2175     2182       +7     
==========================================
+ Hits         2159     2167       +8     
+ Misses         16       15       -1
Impacted Files Coverage Δ
lib/google/gax/grpc.rb 94.44% <100%> (+0.32%) :arrow_up:
spec/google/gax/grpc_spec.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/bundling_spec.rb 100% <0%> (+0.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5f9e88...f7a7042. Read the comment docs.

blowmage commented 5 years ago

@dazuma The other PR says: "focusing this work only on micro-generators" If so, do we need to make this change on 1.x?

dazuma commented 5 years ago

@blowmage The following comment in the other issue then says: "On second thought, we want clients to be safe as early as possible so we should disable it here as well asap"

blowmage commented 5 years ago

Wait, so you are telling me reading comprehension still a thing? man...