dazuma commented 5 years ago

This is to support overriding the backend service address. (Currently it is possible in the clients by subclassing the client class, but it still fails for the associated Longrunning client and there doesn't seem to be a recourse other than monkeypatching.) This will go into the 1.x branch. In the 2.0 branch, this should be controlled by configuration.

codecov[bot] commented 5 years ago

Codecov Report

Merging #215 into 1.x will decrease coverage by 1.06%. The diff coverage is 96%.

@@            Coverage Diff             @@
##              1.x     #215      +/-   ##
==========================================
- Coverage   99.26%   98.19%   -1.07%     
==========================================
  Files          20       22       +2     
  Lines        2182     2276      +94     
==========================================
+ Hits         2166     2235      +69     
- Misses         16       41      +25

Impacted Files	Coverage Δ
lib/google/longrunning/operations_client.rb	`66.19% <100%> (ø)`
spec/google/longrunning_spec.rb	`95.65% <95.65%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f9a5a8...f965ce0. Read the comment docs.

dazuma commented 5 years ago

Yes, I'm synth-ing these into the GAPIC clients, but we need to start with this one to make sure the LRO client follows suit.

googleapis / gax-ruby

Support overriding service address and port via parameters #215

Codecov Report