Closed dazuma closed 5 years ago
Merging #216 into master will increase coverage by
1.29%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 97.96% 99.26% +1.29%
==========================================
Files 46 20 -26
Lines 2608 2174 -434
==========================================
- Hits 2555 2158 -397
+ Misses 53 16 -37
Impacted Files | Coverage Δ | |
---|---|---|
lib/google/gax/operation.rb | 100% <ø> (ø) |
:arrow_up: |
spec/google/gax/util_spec.rb | 100% <ø> (ø) |
|
lib/google/gax/grpc.rb | 94.11% <ø> (-5.89%) |
:arrow_down: |
lib/google/gax/errors.rb | 100% <ø> (+4.76%) |
:arrow_up: |
lib/google/gax/constants.rb | 100% <ø> (ø) |
|
lib/google/gax/path_template.rb | 100% <ø> (ø) |
|
lib/google/gax/bundling.rb | 99.37% <ø> (ø) |
|
spec/google/gax/settings_spec.rb | 100% <ø> (ø) |
|
spec/google/gax/bundling_spec.rb | 99.71% <ø> (ø) |
|
lib/google/gax/util.rb | 97.82% <ø> (ø) |
|
... and 71 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e7c23d0...f6744d7. Read the comment docs.
Merging #216 into master will increase coverage by
1.34%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 97.96% 99.31% +1.34%
==========================================
Files 46 20 -26
Lines 2608 2174 -434
==========================================
- Hits 2555 2159 -396
+ Misses 53 15 -38
Impacted Files | Coverage Δ | |
---|---|---|
lib/google/gax/operation.rb | 100% <ø> (ø) |
:arrow_up: |
spec/google/gax/util_spec.rb | 100% <ø> (ø) |
|
lib/google/gax/grpc.rb | 94.11% <ø> (-5.89%) |
:arrow_down: |
lib/google/gax/errors.rb | 100% <ø> (+4.76%) |
:arrow_up: |
lib/google/gax/constants.rb | 100% <ø> (ø) |
|
lib/google/gax/path_template.rb | 100% <ø> (ø) |
|
lib/google/gax/bundling.rb | 99.37% <ø> (ø) |
|
spec/google/gax/settings_spec.rb | 100% <ø> (ø) |
|
spec/google/gax/bundling_spec.rb | 100% <ø> (ø) |
|
lib/google/gax/util.rb | 97.82% <ø> (ø) |
|
... and 71 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e7c23d0...f6744d7. Read the comment docs.
Merging #216 into master will increase coverage by
0.04%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 98.19% 98.24% +0.04%
==========================================
Files 22 22
Lines 2276 2276
==========================================
+ Hits 2235 2236 +1
+ Misses 41 40 -1
Impacted Files | Coverage Δ | |
---|---|---|
spec/google/gax/bundling_spec.rb | 100% <0%> (+0.28%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3b83ec9...f6744d7. Read the comment docs.
Merging #216 into master will increase coverage by
1.29%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 97.96% 99.26% +1.29%
==========================================
Files 46 20 -26
Lines 2608 2175 -433
==========================================
- Hits 2555 2159 -396
+ Misses 53 16 -37
Impacted Files | Coverage Δ | |
---|---|---|
lib/google/gax/operation.rb | 100% <ø> (ø) |
:arrow_up: |
spec/google/gax/util_spec.rb | 100% <ø> (ø) |
|
lib/google/gax/grpc.rb | 94.11% <ø> (-5.89%) |
:arrow_down: |
lib/google/gax/errors.rb | 100% <ø> (+4.76%) |
:arrow_up: |
lib/google/gax/constants.rb | 100% <ø> (ø) |
|
lib/google/gax/path_template.rb | 100% <ø> (ø) |
|
lib/google/gax/bundling.rb | 99.37% <ø> (ø) |
|
spec/google/gax/settings_spec.rb | 100% <ø> (ø) |
|
spec/google/gax/bundling_spec.rb | 99.71% <ø> (ø) |
|
lib/google/gax/util.rb | 97.82% <ø> (ø) |
|
... and 71 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e7c23d0...f6744d7. Read the comment docs.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent.
in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla
label to yes
(if enabled on your project).
ℹ️ Googlers: Go here for more info.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
ℹ️ Googlers: Go here for more info.
This reverts commits, and merges a bunch of commits that were already CLA-covered.
Did you try renaming master to 2.x and then renaming 1.x to master?
@blowmage Master branch protection won't let me 😞
Obsolete.
The 2.0 development has been moved into https://github.com/googleapis/gapic-generator-ruby so we are switching master back to 1.x. I can't rebase master in this repo, so this includes a commit that reverts all the 2.0 development, and then merges in the existing 1.x branch.
Notes: