search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Allow spaces in path template render bindings #225

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

This change allows spaces to be present in the bindings passed to PathTemplate#render.

codecov[bot] commented 5 years ago

Codecov Report

Merging #225 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   98.23%   98.28%   +0.04%     
==========================================
  Files          23       23              
  Lines        2328     2336       +8     
==========================================
+ Hits         2287     2296       +9     
+ Misses         41       40       -1
Impacted Files Coverage Δ
lib/google/gax/path_template.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/path_template_spec.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/bundling_spec.rb 100% <0%> (+0.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a913fa...09de4e5. Read the comment docs.

blowmage commented 5 years ago

This is related to googleapis/google-cloud-ruby#4291