search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Specify minimum googleapis-common-protos-types dependency #226

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

The inherited common protos types dependency from google-protobuf is ~> 1.0, but libraries using newer annotations need at least version 1.0.4. Since Gax specifying an updated common protos dependency, it should specify an updated common protos types dependency as well.

[refs googleapis/google-cloud-ruby#4289]

codecov[bot] commented 5 years ago

Codecov Report

Merging #226 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          23       23           
  Lines        2328     2328           
=======================================
  Hits         2287     2287           
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c68447c...f23d977. Read the comment docs.