search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Add specs for PagedEnumerable #227

Closed blowmage closed 4 years ago

blowmage commented 4 years ago

[closes #217]

codecov[bot] commented 4 years ago

Codecov Report

Merging #227 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   98.25%   98.23%   -0.02%     
==========================================
  Files          22       23       +1     
  Lines        2287     2328      +41     
==========================================
+ Hits         2247     2287      +40     
- Misses         40       41       +1
Impacted Files Coverage Δ
spec/fixtures/fixture_pb.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/paged_enumerable_spec.rb 100% <100%> (ø)
spec/google/gax/bundling_spec.rb 99.71% <0%> (-0.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92aeaf5...ffb1ed5. Read the comment docs.

blowmage commented 4 years ago

You add 125 lines of tests and code coverage still decreases by 0.01%...

dazuma commented 4 years ago

Thanks a lot codecov. WTF are you doing anyway?