googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Enable master branch protection #230

Closed JustinBeckwith closed 4 years ago

JustinBeckwith commented 4 years ago
      This repository does not seem to have master branch
      protection enabled, at least in the way I'm expecting.
      I was hoping for:

      - master branch protection
      - requiring at least one code reviewer
      - requiring at least two status checks
      - enforcing rules for admins

      Please turn it on!
hkdevandla commented 4 years ago

@dazuma , friendly ping to take a look and fix it.

hkdevandla commented 4 years ago

@viacheslav-rostovtsev , should this be on us (actools@) to enable this protection since we manage this repo? Please advice. We have to enable this otherwise it would gate Justin Beckwith's proposal to open up the googleapis/ for googlers. Thanks!