search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Add GAX error details attribute #89

Closed geigerj closed 6 years ago

geigerj commented 6 years ago

The details attribute provides easy access to deserialized error details. Previously, API custom error types were only accessible by inspecting the gRPC error, and then only availabe in serialized form.

Fixes https://github.com/GoogleCloudPlatform/google-cloud-ruby/issues/1438

codecov-io commented 6 years ago

Codecov Report

Merging #89 into master will decrease coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   98.64%   98.61%   -0.03%     
==========================================
  Files          20       20              
  Lines        1767     1803      +36     
==========================================
+ Hits         1743     1778      +35     
- Misses         24       25       +1
Impacted Files Coverage Δ
lib/google/gax/grpc.rb 100% <100%> (ø) :arrow_up:
lib/google/gax/errors.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/grpc_spec.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/bundling_spec.rb 99.69% <0%> (-0.31%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd59665...a3305df. Read the comment docs.