search

googleapis / gaxios

An HTTP request client that provides an axios like interface over top of node-fetch. Super lightweight. Supports proxies and all sorts of other stuff.
Apache License 2.0
796 stars 60 forks source link

Upgrade node-fetch dependency to v3.2 #508

Closed adarshmadrecha closed 3 weeks ago

adarshmadrecha commented 2 years ago

Is your feature request related to a problem? Please describe. When using firebase-admin in Nuxt3 Project along with Mongoose, it causes clash becase of use of different versions of node-fetch by underlying libraries.

image image

Describe the solution you'd like Upgrade to latest version of node-fetch i.e. 3.2.x

Describe alternatives you've considered Have added overrides in the package.json, but it does not work because of the way it is imported in the gaxios.

"overrides": {
      "node-fetch": "3.2.10"
 }

image

Additional context

ddelgrosso1 commented 2 years ago

Hi @adarshmadrecha thanks for opening this issue. Currently we are unable to update to node-fetch 3.x as it has moved to a pure ESM package. Please see https://github.com/googleapis/gaxios/issues/429 for additional context.

mbrevda commented 10 months ago

as it has moved to a pure ESM package

It would be great if you can elaborate more on how moving to a pure esm package creates a blocker?

adarshmadrecha commented 10 months ago

As mentioned in https://github.com/googleapis/gaxios/issues/429#issuecomment-1833097220 Starting with node v21, this issue will have to be resolved.