search

googleapis / google-api-nodejs-client

Google's officially supported Node.js client library for accessing Google APIs. Support for authorization and authentication with OAuth 2.0, API Keys and JWT (Service Tokens) is included.
https://googleapis.dev/nodejs/googleapis/latest/
Apache License 2.0
11.26k stars 1.91k forks source link

Should `sideEffects` be boolean `false` ? esbuild is complaining about it since the 128.0.0 release: #3419

Open thblt-thlgn opened 5 months ago

thblt-thlgn commented 5 months ago

Should sideEffects be boolean false ? esbuild is complaining about it since the 128.0.0 release:

▲ [WARNING] The value for "sideEffects" must be a boolean or an array [package.json]

    ./node_modules/googleapis/package.json:9:17:
      9 │   "sideEffects": "false",
        ╵                  ^

1 warning

Webpack documents it similarly as boolean | string[]

Originally posted by @mhio in https://github.com/googleapis/google-api-nodejs-client/issues/3354#issuecomment-1776999824