googleapis / google-api-nodejs-client

Google's officially supported Node.js client library for accessing Google APIs. Support for authorization and authentication with OAuth 2.0, API Keys and JWT (Service Tokens) is included.
https://googleapis.dev/nodejs/googleapis/latest/
Apache License 2.0
11.26k stars 1.91k forks source link

fix: package.json sideEffects field should be a boolean #3428

Closed blimmer closed 3 months ago

blimmer commented 5 months ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Resolves esbuild error:

▲ [WARNING] The value for "sideEffects" must be a boolean or an array [package.json]

    node_modules/googleapis/package.json:9:17:
      9 │   "sideEffects": "false",
        ╵                  ^

1 warning

Fixes #3419

Closes #2918 (should have been closed before)

google-cla[bot] commented 5 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

vdvleon commented 4 months ago

Any progress on this fix? I would love to have this 👼

konstrybakov commented 4 months ago

+1

alexmcode commented 4 months ago

+1