googleapis / google-api-nodejs-client

Google's officially supported Node.js client library for accessing Google APIs. Support for authorization and authentication with OAuth 2.0, API Keys and JWT (Service Tokens) is included.
https://googleapis.dev/nodejs/googleapis/latest/
Apache License 2.0
11.26k stars 1.91k forks source link

fix: Change sideEffects value to boolean #3438

Closed filipechagas closed 4 months ago

filipechagas commented 4 months ago

As described in Webpack documentation, this field is boolean or string[]

Check https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes https://github.com/googleapis/google-api-nodejs-client/issues/3419 🦕

filipechagas commented 4 months ago

I see there's already a PR for that https://github.com/googleapis/google-api-nodejs-client/pull/3428#pullrequestreview-1885578244