search

googleapis / google-api-php-client

A PHP client library for accessing Google APIs
Apache License 2.0
9.2k stars 3.52k forks source link

fix: Add AllowDynamicProperties annotation in Service class #2550

Closed ajupazhamayil closed 2 months ago

ajupazhamayil commented 6 months ago

Resolves https://github.com/googleapis/google-api-php-client-services/issues/4106

ajupazhamayil commented 6 months ago

Just to be clear before we merge this - where is it that dynamic properties are being used for Service classes? Can you identify where it's happening (so we can also confirm that this is the right action to take)?

Hmm.. I was thinking about the ShoppingContent or similar classes extending the Service class. But, I just looked at them and the classes I should be concentrating are classes which extends Model class. Further, Model class already has the required annotation. Seems like I got confused on the base classes and this PR may not help in our scenario! My bad!