search

googleapis / google-auth-library-nodejs

🔑 Google Auth Library for Node.js
Apache License 2.0
1.73k stars 381 forks source link

refactor!: Remove `src/options.ts` #1658

Open danielbankhead opened 1 year ago

danielbankhead commented 1 year ago

It's pretty legacy at this point and we can clean up this unnecessary code.

https://github.com/googleapis/google-auth-library-nodejs/blob/5f296c37390ba71aa3aa1e4259ff7c525eeaad7c/src/options.ts#L20-L32

NewtonFernandis commented 1 year ago

Hi @danielbankhead, I would like to work on this. Could you please assign this to me?

danielbankhead commented 1 year ago

@NewtonFernandis Absolutely, take your time as we won't be able to merge this fix until the library's next major release (likely sometime next year).

NewtonFernandis commented 1 year ago

Cool 💯