search

googleapis / google-auth-library-nodejs

🔑 Google Auth Library for Node.js
Apache License 2.0
1.73k stars 381 forks source link

chore(main): release 9.4.0 #1704

Closed release-please[bot] closed 11 months ago

release-please[bot] commented 11 months ago

:robot: I have created a release beep boop

9.4.0 (2023-11-30)

Features

This PR was generated with Release Please. See documentation.

JrSchild commented 11 months ago

@danielbankhead can we prioritize this, or at least release it as a patch? It is currently breaking production environments, especially for projects with automatic dependency updates.

Much appreciated 🙏.

release-please[bot] commented 11 months ago

:robot: Release is at https://github.com/googleapis/google-auth-library-nodejs/releases/tag/v9.4.0 :sunflower:

release-trigger[bot] commented 11 months ago

Triggered job: cloud-devrel/client-libraries/nodejs/release/googleapis/google-auth-library-nodejs/publish (2023-11-30T15:22:40.844Z)

To trigger again, remove the autorelease: triggered label (in a few minutes).

release-tool-publish-reporter[bot] commented 11 months ago

The release build has started, the log can be viewed here. :sunflower:

release-tool-publish-reporter[bot] commented 11 months ago

:egg: You hatched a release! The release build finished successfully! :purple_heart:

austinkline commented 11 months ago

Any plans for an RCA for what happened here? Tracking this down was incredibly difficult last night, and I had to make some substantial changes to my backend to get around it until today's patch.

Was there some place I'm not aware of to have tracked this issue? I didn't see anything reported on GCP's status page

danielbankhead commented 11 months ago

@austinkline typically we have renovatebot update our dependencies, however it hasn’t triggered for this dep (investigating). Additionally, a fresh install of this library would have pulled in the updated gcp-metadata library, which is how it passed in our testing environment.

austinkline commented 11 months ago

@austinkline typically we have renovatebot update our dependencies, however it hasn’t triggered for this dep (investigating). Additionally, a fresh install of this library would have pulled in the updated gcp-metadata library, which is how it passed in our testing environment.

Can you clarify what you mean by a fresh install? I tried to pull in the newest version of the auth library last night but it gave us no relief and so I had to offload all connections to other GCP services (pub/sub for us) from cloud functions somewhere else. Now that I've pulled in 9.4.0, I see the gcp-metadata version being bumped with it as well.

danielbankhead commented 11 months ago

Can you clarify what you mean by a fresh install? I tried to pull in the newest version of the auth library last night but it gave us no relief

rm -rf node_modules package-lock.json && npm i

so I had to offload all connections to other GCP services (pub/sub for us) from cloud functions somewhere else

That’s rough; I’ll investigate this dependency update failure to reduce the risk of this happening in the future.