refactor!: Move Base `AuthClient` Types to `authclient.ts`

googleapis / google-auth-library-nodejs

🔑 Google Auth Library for Node.js

Apache License 2.0

1.71k stars 374 forks source link

refactor!: Move Base `AuthClient` Types to `authclient.ts` #1773

Open danielbankhead opened 6 months ago

danielbankhead commented 6 months ago

Today, there are types imported from other AuthClients that should be in the base client's file. E.g.:

https://github.com/googleapis/google-auth-library-nodejs/blob/f45f9753a7c83bc04616a1bdbaf687b3f38a17d2/src/auth/authclient.ts#L20

These should be moved here and the imports should be updated throughout the codebase accordingly.

Implementation Notes:

Ensure any top-level exports in src/index.ts work seamlessly

HubertJan commented 6 months ago

Hi @danielbankhead, I'd like to work on that.

Which other types should be moved to authclient.ts? At the moment, only GetAccessTokenResponse and Headers are directly imported from oauth2client.

danielbankhead commented 6 months ago

Thanks!

At the moment, only GetAccessTokenResponse and Headers are directly imported from oauth2client.

Today, only those two types should be moved. As this functionality will not be released until the next major release, it's left intentionally open in case a type slips through in the meantime.