search

googleapis / google-auth-library-nodejs

🔑 Google Auth Library for Node.js
Apache License 2.0
1.74k stars 382 forks source link

refactor!: Move Base AuthClient Types to authclient.ts #1774

Open HubertJan opened 8 months ago

HubertJan commented 8 months ago

Fixes #1773 🦕

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

conventional-commit-lint-gcf[bot] commented 8 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

HubertJan commented 8 months ago

The linter was failing, I fixed that now. I hope we can merge now :)

danielbankhead commented 8 months ago

@HubertJan thanks! We'll merge it in the next major