search

googleapis / google-auth-library-php

Google Auth Library for PHP
http://googleapis.github.io/google-auth-library-php/
Apache License 2.0
1.33k stars 190 forks source link

chore: drop deprecated Item class #569

Closed artemkurylo closed 2 months ago

artemkurylo commented 2 months ago

Drop deprecated Item class.

This class isn't used anymore and was deprecated along with drop of PHP 7.4. As a destructive example of it's presence, one of the projects that I'm working on tries to load every file from vendor directory into the memory and this class breaks it, because it doesn't comply with CacheItemInterface interface (missing return types, which results in a fatal error).

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

bshaffer commented 2 months ago

As long as we support psr/cache: ^2.0, we need these item classes

https://github.com/googleapis/google-auth-library-php/blob/1277062739eedd04e7d0af86f6fe1853d2620706/composer.json#L17

artemkurylo commented 2 months ago

Ah, didn't notice it, makes sense. Thanks for taking a look. Then we can close this one until team decides to drop the support for it.