search

googleapis / google-auth-library-python

Google Auth Python Library
https://googleapis.dev/python/google-auth/latest/
Apache License 2.0
773 stars 305 forks source link

Invalid `dev` version identifiers in `setup.py` #1321

Closed con-f-use closed 1 year ago

con-f-use commented 1 year ago

There is a bunch of ~invalid~ version matchers (edit: valid, but not parsed correctly by distlib) in setup.py. PEP 440 states:

The canonical public version identifiers MUST comply with the following scheme: [N!]N(.N)*[{a|b|rc}N][.postN][.devN]

So you are missing a dot and a number in every version identifier that contains the string dev.

It is also considered bad practice to have an upper bound on package versions and installers like pip do not typically consider development versions in any case (unless explicitly told to).

See: https://github.com/googleapis/google-api-python-client/issues/2151

con-f-use commented 1 year ago

Discussion in: https://github.com/googleapis/python-api-core/issues/504