search

googleapis / google-auth-library-python

Google Auth Python Library
https://googleapis.dev/python/google-auth/latest/
Apache License 2.0
755 stars 303 forks source link

fix: Change log level to debug for return_none_for_not_found_error #1468

Closed rgryta closed 5 months ago

rgryta commented 5 months ago

At the moment google-auth library produces a lot of logging messages when universal domain isn't found on the server - logging message includes the entirety of GCP HTML 404 website contents.

google-cla[bot] commented 5 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

conventional-commit-lint-gcf[bot] commented 5 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

arithmetic1728 commented 5 months ago

Thank you for the changes! Could you sign the CLA and change the commit message to "fix: Change log level to debug for return_none_for_not_found_error"?

rgryta commented 5 months ago

At the moment google-auth library produces a lot of logging messages when universal domain isn't found on the server - logging message includes the entirety of GCP HTML 404 website contents.

Hi, did so, but github wouldn't let me reopen the PR after amending the commit message. Reopened under: https://github.com/googleapis/google-auth-library-python/pull/1469