search

googleapis / google-cloud-cpp-spanner

C++ client library for Google Cloud Spanner
https://cloud.google.com/spanner/
Apache License 2.0
29 stars 14 forks source link

feat: allow injecting a Clock into the `SessionPool` for testing #1449

Closed mr-salty closed 4 years ago

mr-salty commented 4 years ago

fixes #1428

This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #1449 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
- Coverage   95.61%   95.59%   -0.02%     
==========================================
  Files         190      191       +1     
  Lines       15788    15792       +4     
==========================================
+ Hits        15095    15097       +2     
- Misses        693      695       +2
Impacted Files Coverage Δ
google/cloud/spanner/internal/session_pool.h 0% <ø> (ø) :arrow_up:
google/cloud/spanner/internal/session_pool.cc 91.84% <100%> (-0.4%) :arrow_down:
google/cloud/spanner/internal/session_pool_test.cc 99.57% <100%> (ø) :arrow_up:
google/cloud/spanner/testing/fake_clock.h 100% <100%> (ø)
google/cloud/spanner/internal/session.h 100% <100%> (ø) :arrow_up:
...on_tests/rpc_failure_threshold_integration_test.cc 85.55% <0%> (-2.09%) :arrow_down:
google/cloud/spanner/internal/spanner_stub.cc 76.34% <0%> (-1.08%) :arrow_down:
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 91.96% <0%> (-0.01%) :arrow_down:
google/cloud/spanner/keys.h 100% <0%> (ø) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b926894...6395b5d. Read the comment docs.

devjgm commented 4 years ago

I believe this PR is no longer needed since https://github.com/googleapis/google-cloud-cpp-spanner/pull/1452