search

googleapis / google-cloud-cpp

C++ Client Libraries for Google Cloud Services
https://cloud.google.com/
Apache License 2.0
545 stars 364 forks source link

generator: consider converting repeated fields to HTTP query parameters #10176

Open scotthart opened 1 year ago

scotthart commented 1 year ago

Currently, we skip repeated fields found in proto request messages when formatting query parameters for GET requests. This may or may not be correct and needs some investigation.

coryan commented 1 year ago

Closing for now, does not seem to be needed.

dbolduc commented 1 month ago

If these fields are not included in the body, then they are not currently sent over the wire.

We have to include them as query parameters. Luckily, the google.api.http proto is well documented and tells us how to do it:

https://github.com/googleapis/googleapis/blob/a91d1a37cb86a0e49fdc21d8b4416eb1c2a083ec/google/api/http.proto#L116-L117