googleapis / google-cloud-cpp

C++ Client Libraries for Google Cloud Services
https://cloud.google.com/
Apache License 2.0
551 stars 373 forks source link

WinSvc.h macro mangling methods named CreateService #11893

Open scotthart opened 1 year ago

scotthart commented 1 year ago

Because of the unfortunate preprocessor definition in WinSvc.h,

#ifdef UNICODE
#define CreateService  CreateServiceW
#else
#define CreateService  CreateServiceA
#endif // !UNICODE

services that define an rpc named "CreateService" get mangled when building on windows.

This is both a problem for us as well as grpc.

scotthart commented 1 year ago

related: https://github.com/grpc/grpc/issues/33501

coryan commented 11 months ago

Blocked on gRPC doing something or C++20 modules.

scotthart commented 5 months ago

Still blocked on gRPC