googleapis / google-cloud-cpp

C++ Client Libraries for Google Cloud Services
https://cloud.google.com/
Apache License 2.0
554 stars 375 forks source link

Catch up with missing services #13847

Closed coryan closed 7 months ago

coryan commented 8 months ago

A number of proto files listed in the *.list files with RPC services defined are missing from the generator_config.textproto file:

comm -23 \
    <(git ls-files -- external/googleapis/protolists/*.list | \
            xargs sed -e 's;@com_google_googleapis//;;' -e 's;:;/;' | \
            xargs env -C .build/external/googleapis/src/googleapis_download grep -l '^service ' | sort) \
     <(sed -n  '/service_proto_path:/ {s/.*_path: "//; s/"//p}' generator/generator_config.textproto | sort) 
dbolduc commented 8 months ago

We should give extra scrutiny to services that were not added as part of #12168. Although some of them may be GA by now.