Open scotthart opened 1 month ago
Just to checkpoint progress before I go on a mini-vacation...
I have generator changes in a branch: https://github.com/dbolduc/google-cloud-cpp/tree/generator-rest-query-params-dev. It also addresses #10176.
The code looks right to my eye, but I haven't written tests. Golden unit tests are where we need to do the bulk of the testing. Existing integration tests should at least give us confidence things are no worse than before. They won't verify the new functionality though.
The PR is too big already. I will want to break it down:
body = "*"
params
argument to the rest_internal::Verb(...)
. This will be the majority of the line changes, although the PR should be trivial.
For Requests that have query parameters nested in messages, we need to synthesize qualified names for those parameters and include them in the URL.
for this example, the URL should be something like: