search

googleapis / google-cloud-cpp

C++ Client Libraries for Google Cloud Services
https://cloud.google.com/
Apache License 2.0
554 stars 374 forks source link

chore: update vcpkg to 2024-10-21 #14816

Open ddelgrosso1 opened 3 weeks ago

ddelgrosso1 commented 3 weeks ago

This change is Reviewable

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.27%. Comparing base (d58ddd2) to head (59d1290). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #14816 +/- ## ========================================== - Coverage 93.27% 93.27% -0.01% ========================================== Files 2319 2319 Lines 208297 208410 +113 ========================================== + Hits 194297 194390 +93 - Misses 14000 14020 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dbolduc commented 3 weeks ago

Hm. It seems like the jump from c-ares 1.33.1 -> 1.34.1 in vcpkg is causing grpc::GoogleDefaultCredentials() to assert in our tests on windows. I don't know why. :upside_down_face:

ddelgrosso1 commented 2 weeks ago

https://github.com/grpc/grpc/issues/37969