search

googleapis / google-cloud-cpp

C++ Client Libraries for Google Cloud Services
https://cloud.google.com/
Apache License 2.0
554 stars 374 forks source link

impl(generator): handle deprecated services #14849

Closed scotthart closed 2 days ago

scotthart commented 3 days ago

v29 of protobuf adds [[deprecated]] attributes to proto message types generated from deprecated services. We need to disable compiler warnings on these types because of -Werror until we remove the deprecated services.

This change is Reviewable

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 51.88172% with 179 lines in your changes missing coverage. Please review.

Project coverage is 93.00%. Comparing base (000bb23) to head (cb3c9f3). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...s/golden/v1/internal/deprecated_connection_impl.cc 28.57% 15 Missing :warning:
...den/v1/internal/deprecated_rest_connection_impl.cc 0.00% 15 Missing :warning:
.../v1/internal/deprecated_rest_metadata_decorator.cc 0.00% 14 Missing :warning:
...n_tests/golden/v1/internal/deprecated_rest_stub.cc 0.00% 14 Missing :warning:
...golden/v1/internal/deprecated_rest_stub_factory.cc 0.00% 13 Missing :warning:
...ests/golden/v1/internal/deprecated_tracing_stub.cc 0.00% 12 Missing :warning:
...olden/v1/internal/deprecated_metadata_decorator.cc 42.10% 11 Missing :warning:
...ntegration_tests/golden/v1/deprecated_connection.h 58.33% 10 Missing :warning:
...tion_tests/golden/v1/deprecated_rest_connection.cc 0.00% 10 Missing :warning:
...olden/v1/internal/deprecated_tracing_connection.cc 25.00% 9 Missing :warning:
... and 18 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #14849 +/- ## ========================================== - Coverage 93.07% 93.00% -0.08% ========================================== Files 2319 2351 +32 Lines 209109 209479 +370 ========================================== + Hits 194630 194824 +194 - Misses 14479 14655 +176 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: