search

googleapis / google-cloud-cpp

C++ Client Libraries for Google Cloud Services
https://cloud.google.com/
Apache License 2.0
554 stars 375 forks source link

Investigate using grpc++_test_util #2941

Closed mr-salty closed 3 years ago

mr-salty commented 5 years ago

grpc has a grpc++_test_util library; investigate whether we can/should use this in our projects. At the moment, we've at least re-made MockClientReader in both bigtable and spanner libraries

mr-salty commented 5 years ago

in chat, @coryan said:

It does not seem like gRPC installs that header. So the first step is to figure out what magical incantations in the cmake and/or make configuration for gRPC would get it to actually install the header. Then you need to figure out if that would break the install instructions in google-cloud-cpp/INSTALL.md, I think we recommend using the system version of gRPC in some cases.

devjgm commented 3 years ago

It doesn't look like grpc exposes this library for callers, and I suspect it's not worth the effort for us to ask/make them do it, IMO.

mr-salty commented 3 years ago

fyi i couldn't find an easy way to mass unsubscribe from issues so please know that i'm just sitting here silently judging you as these fly by ;)

j/k (or am i?), hope you and the rest of the team are doing well. bradley tells me that new salty is doing great.

devjgm commented 3 years ago

haha.. sorry for the noise. Hope you're doing well too.

coryan commented 3 years ago

Maybe "unwatch" on the upper right corner of this page? It has a "never be notified" option.

mr-salty commented 3 years ago

ah, i don't really mind, they're occasional enough that it's nice to see... just thought i'd take the opportunity to say hi and mess with you a ittle.

carlos - i unwatched the project but you also get subscribed to any issue/pr/etc you interact with, and there's no bulk unsubscribe. here's someone who is saltier than I am about it: https://drewdevault.com/2021/03/09/github-refuses-to-help-me-unsubscribe.html (well, from that i guess you can do 25 at a time which i'm not sure i realized, but...)