search

googleapis / google-cloud-dotnet

Google Cloud Client Libraries for .NET
https://cloud.google.com/dotnet/docs/reference/
Apache License 2.0
938 stars 366 forks source link

Google.Cloud.Diagnostics.Common.Tests.RateLimiterTest.CanTrace_StressTest is flaky #1044

Closed jskeet closed 7 years ago

jskeet commented 7 years ago

Running the test in net452, I'm getting occasional failures, e.g.

[xUnit.net 00:00:09.8397567]     Google.Cloud.Diagnostics.Common.Tests.RateLimiterTest.CanTrace_StressTest [FAIL]
[xUnit.net 00:00:09.8407245]       Assert.InRange() Failure
[xUnit.net 00:00:09.8408755]       Range:  (6 - 7)
[xUnit.net 00:00:09.8409397]       Actual: 2
iantalarico commented 7 years ago

How often are these failures happening? I'm having trouble repoing.

jskeet commented 7 years ago

I ran the code locally and it was about 50/50. My pull request earlier today had to be restarted a few times :(

(I'm not sure whether it was always net452 that failed. If so, that could be a hint...)

jskeet commented 7 years ago

Hmm. I can't reproduce either now. Will close for the time being.