googleapis / google-cloud-go

Google Cloud Client Libraries for Go.
https://cloud.google.com/go/docs/reference
Apache License 2.0
3.72k stars 1.28k forks source link

recommender: v1beta1 Grpc Recommender Client lacking locations calls #10559

Open murarustefaan opened 2 months ago

murarustefaan commented 2 months ago

Client

Recommender GRPC

Environment

N/A

Go Environment

N/A

Code

N/A

Expected behavior

Go recommender client should have Location methods exposed in the docs.

https://pkg.go.dev/cloud.google.com/go/recommender/apiv1beta1#Client.ListRecommendations https://cloud.google.com/recommender/docs/reference/rest/v1beta1/organizations.locations/list https://cloud.google.com/recommender/docs/reference/rest/v1beta1/projects.locations/list https://cloud.google.com/recommender/docs/reference/rest/v1beta1/folders.locations/list

Actual behavior

Go recommender client does not have any location methods.

Additional context

Trying to pull recommendations from all locations, but it does not make sense to waste API calls to regions that do not have recommendations at all.

I am willing to work on this if it's something I'm able to do, provided you can share some hints on where to start.

codyoss commented 2 months ago

Thank you for the report. I have reported this internally so we can get this fixed.

Internal Bug: 355625308