search

googleapis / google-cloud-go

Google Cloud Client Libraries for Go.
https://cloud.google.com/go/docs/reference
Apache License 2.0
3.78k stars 1.3k forks source link

feat(storage): allow non default service account #11137

Closed frankyn closed 1 week ago

frankyn commented 1 week ago

Since Go Storage enables DirectPath by default, the client needs to enable the flag to allow non-default service accounts as well.

In talking with @mohanli-ml, there's an approval process that GCS has already done as a service and we only need to enable it client side. Mohan can i get your approval on this PR to ack this context?

Fixes: #11128 Triggered a continuous job with this PR: image

frankyn commented 1 week ago

Cloudtop works you just need to set environment variable:

GOOGLE_CLOUD_DISABLE_DIRECT_PATH=false

Direct Connectivity is disabled by default on cloudtop.