search

googleapis / google-cloud-go

Google Cloud Client Libraries for Go.
https://cloud.google.com/go/docs/reference
Apache License 2.0
3.8k stars 1.31k forks source link

fix(spanner): do not mutate incoming options in createGCPMultiEndpoint #11151

Open nimf opened 1 week ago

rahul2393 commented 1 week ago

@nimf What is the issue this PR is fixing, can you also please add a failing test it will help me in understanding changes better.

nimf commented 1 week ago

Sorry, this is a followup of this conversation: https://github.com/googleapis/google-cloud-go/pull/9565#discussion_r1847404503

rahul2393 commented 1 week ago

Thanks, is it possible to add failing test with current code?

nimf commented 6 days ago

Thanks, is it possible to add failing test with current code?

Yes, let me add that.

nimf commented 6 days ago

@rahul2393 can you trigger the kokoro run, please?

nimf commented 12 hours ago

This is another test failing, not related to the changes. It passes locally, but fails in the kokoro env. I will investigate.