spanner: integration tests should be moved out of spanner package

googleapis / google-cloud-go

Google Cloud Client Libraries for Go.

https://cloud.google.com/go/docs/reference

Apache License 2.0

3.76k stars 1.29k forks source link

spanner: integration tests should be moved out of spanner package #8924

Open ghost opened 1 year ago

ghost commented 1 year ago

spanner/integration_test.go is in package spanner. As a result, it can access package-visible members which may not be visible to public. The integration tests should use the public API only to mimic client app behaviour.

https://github.com/googleapis/google-cloud-go/pull/8923 is an example of a bug that wouldn't have happened if the tests were in a package other than spanner.

surbhigarg92 commented 1 year ago

@rahul2393 Can you please triage this issue

noahdietz commented 11 months ago

Tagged as a feature request for rotation triaging. Feel free to change.

noahdietz commented 11 months ago

Accidentally closed, apologies, reopened.