search

googleapis / google-cloud-node

Google Cloud Client Library for Node.js
https://cloud.google.com/nodejs
Apache License 2.0
2.91k stars 592 forks source link

Are we logging debug stuff accidentally? #1204

Closed jgeewax closed 8 years ago

jgeewax commented 8 years ago

I have the following script:

var projectId = 'my project';
var gcloud = require('gcloud')({projectId: projectId});
var datastore = gcloud.datastore();

var query = datastore.createQuery('TodoList'); // (1)
datastore.runQuery(query)
  .on('data', function(entity) {})
  .on('end', function() {});

When I run it I get this: (note there are no console.log calls in my script)

$ node gcdtest.js
Service URL: https://datastore.googleapis.com/google.datastore.v1beta3.Datastore
Bearer <a long token is here... not exposing it for obvious reasons>
$
jgeewax commented 8 years ago

(Also note that this isn't coming from stderr.... it's stdout AFAICT)

jgeewax commented 8 years ago

I can't seem to find anything in gcloud-node, google-auto-auth, google-auth-library, or grpc/grpc/src/node .... But I'm not as adept at sleuthing as you guys...

stephenplusplus commented 8 years ago

It's from grpc: https://github.com/grpc/grpc/issues/5967#issuecomment-204460329. We need them to release a new version.

christyleung1987 commented 8 years ago

We should get rid of logging. console.log is performance heavy.