googleapis / google-cloud-node

Google Cloud Client Library for Node.js
https://cloud.google.com/nodejs
Apache License 2.0
2.9k stars 592 forks source link

[securitycenter] v2 client's `apiEndpoint` property is wrong when a regional endpoint is specified #5719

Open hegemonic opened 1 week ago

hegemonic commented 1 week ago

Please make sure you have searched for information in the following guides.

A screenshot that you have tested with "Try this API".

n/a

Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.

https://gist.github.com/hegemonic/cf807026d8b83c14aa0b225b16967599

A step-by-step description of how to reproduce the issue, based on the linked reproduction.

Run the code. It creates a v2 SecurityCenterClient; sets the apiEndpoint to securitycenter.me-central2.rep.googleapis.com; and prints the expected and actual apiEndpoint for the client.

A clear and concise description of what the bug is, and what you expected to happen.

The code prints the following:

expected apiEndpoint: securitycenter.me-central2.rep.googleapis.com
actual apiEndpoint: securitycenter.googleapis.com
client._opts.apiEndpoint: securitycenter.me-central2.rep.googleapis.com

I expected it to print the following:

expected apiEndpoint: securitycenter.me-central2.rep.googleapis.com
actual apiEndpoint: securitycenter.me-central2.rep.googleapis.com
client._opts.apiEndpoint: securitycenter.me-central2.rep.googleapis.com

A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **

github-actions[bot] commented 1 week ago

Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)

hegemonic commented 1 week ago

@sofisl Why was this bug closed? I provided a valid link to a publicly visible gist.