search

googleapis / google-cloud-php

Google Cloud Client Library for PHP
https://cloud.google.com/php/docs/reference
Apache License 2.0
1.09k stars 436 forks source link

ci: enable flakybot for test failure detection #7195

Open noahdietz opened 7 months ago

noahdietz commented 7 months ago

We should install the flakybot app to notify us of failing tests in our continuous job.

@vishwarajanand has identified a set of already failing tests. Once we do a bit of clean up, we can start the process of enabling the app on the repo. Those tests that aren't addressed initially should result in new issues being created.

noahdietz commented 7 months ago

Based on the docs, since this repo is in googleapis, the app is already installed. We need to make sure the other setup is aligned.

noahdietz commented 7 months ago

It looks like only a few steps are necessary to enable it at this point. image

here is where we have sponge_log files being created: https://github.com/googleapis/google-cloud-php/blob/8d3c0fd2e3f9676941d9f40f3f51aa2622d05428/.kokoro/continuous/run-tests.sh#L10-L16

but then they are populated with junit format? https://github.com/googleapis/google-cloud-php/blob/8d3c0fd2e3f9676941d9f40f3f51aa2622d05428/.kokoro/continuous/run-tests.sh#L39-L49

not sure if that needs changing.

@vishwarajanand do you mind handling this? It's already installed on the repo per the documentation

vishwarajanand commented 7 months ago

I've fixed all storage tests (few PRs pending reviews though). I am looking for Spanner tests to be fixed (most of them have similar failures). Once thats done, I will look into this.