googleapis / google-cloud-php

Google Cloud Client Library for PHP
https://cloud.google.com/php/docs/reference
Apache License 2.0
1.09k stars 433 forks source link

`google/common-protos` split based on older version #7580

Closed mbabker closed 1 month ago

mbabker commented 1 month ago

https://github.com/googleapis/google-cloud-php/pull/7554 appears to have merged an older release of the google/common-protos repo, removing changes after the 4.5.0 release (on a glance this appears to include https://github.com/googleapis/common-protos-php/pull/85 and https://github.com/googleapis/common-protos-php/pull/88).

Environment details

Steps to reproduce

  1. Compare the state of https://github.com/googleapis/common-protos-php/tree/v4.7.0 to https://github.com/googleapis/common-protos-php/tree/v4.8.0

Code example

N/A

bshaffer commented 1 month ago

@mbabker thank you for catching this, and sorry for the inconvenience. This will be fixed in the next release (tomorrow) by https://github.com/googleapis/google-cloud-php/pull/7591