search

googleapis / google-cloud-php

Google Cloud Client Library for PHP
https://cloud.google.com/php/docs/reference
Apache License 2.0
1.09k stars 436 forks source link

Support google/protobuf 4 in googleapis/common-protos-php #7605

Closed leongersen closed 1 month ago

leongersen commented 2 months ago

7201 in this repository allows setting the dependency for google/protobuf to ^v3.25.3||^4.26.1.

This is not reflected in the released package for googleapis/common-protos-php. The composer.json for that package still depends on google/protobuf ^3.6.1.

leongersen commented 2 months ago

This was correct until this commit, which references #7554.

7580 reports another issue with this merge, which was fixed in #7591.

kellerjmrtn commented 2 months ago

Having a similar issue in my app, can't upgrade googleapis/common-protos-php to the latest versions because my app also requires google/protobuf:^4, and ^4 support seems to have dropped in the latest version

bshaffer commented 1 month ago

This is fixed in https://github.com/googleapis/google-cloud-php/pull/7648 and in version 4.8.3 of google/common-protos

thanks for reporting this!