search

googleapis / google-cloud-python-happybase

Other
21 stars 29 forks source link

Implement Table.regions() #29

Open sduskis opened 6 years ago

sduskis commented 6 years ago

The Java client implements Table.regions() using the SampleRowKeys RPC to get the start/stop keys. The happybase client should do so as well.

dhermes commented 6 years ago

@sduskis This client just has the same features as https://happybase.readthedocs.io/en/latest/

Support should instead go in google-cloud-bigtable.

sduskis commented 6 years ago

Table.regions() is not implemented in google-cloud-python-happybase (see here for code, and here for docs). Sample Row keys is implemented in google-cloud-bigtable (see here). Here's how the Java client implements retrieval of regions via the SampleRowKeys API.

Here's a snippet from the docs:

Some concepts from HBase/Thrift do not map directly to the Cloud Bigtable API. As a result

  • Table.regions() could not be implemented since tables in Cloud Bigtable do not expose internal storage details

I believe that this is a happybase specific issue, and not a google-cloud-bigtable issue. (That said, I don't have access to google-cloud-bigtable yet, so I referred to google-cloud-python instead).

dhermes commented 6 years ago

Ah, big DERP on my part. Sorry.

dhermes commented 6 years ago

I don't have access to google-cloud-bigtable yet

It's just the bigtable directory in the main repo.