search

googleapis / google-cloudevents

Types for CloudEvents issued by Google
http://git.io/google-cloudevents
Apache License 2.0
139 stars 21 forks source link

fix: Correct namespaces for AlloyDB and GkeHub #546

Closed copybara-service[bot] closed 1 year ago

copybara-service[bot] commented 1 year ago

fix: Correct namespaces for AlloyDB and GkeHub

dazuma commented 1 year ago

From internal change cl/546104830:

Correct namespaces for Ruby event proto classes for alloydb and gkehub.

This ensures that the namespaces for the generated event classes for these services matches the corresponding API protos and client libraries.

For GkeHub, it looks like this was just an omission for Ruby and PHP, since the C# namespace was already set correctly.

For AlloyDB, the capitalization for Ruby is intentionally different from C# and PHP, due to differences in language idioms.

This is technically a breaking change, but I don't think PHP is generating these classes yet (see https://github.com/googleapis/google-cloudevents-php), and Ruby has held off on merging the original incorrect names until this fix is in (https://github.com/googleapis/google-cloudevents-ruby/pull/35).